tvkitchen / appliances

A one stop shop for official TV Kitchen Appliances
GNU Lesser General Public License v3.0
3 stars 0 forks source link

Refactor segment generator #106

Closed slifty closed 3 years ago

slifty commented 3 years ago

The VideoSegmentGenerator appliance was using the old timestamp field and needed to be updated to use origin. This also helped highlight some of the difficult-to-parse variable and method names.

Instead of using origin in the segment appliance, it is startingAt which has more intuitive meaning. Some of the internal methods have been reworded as well with the goal of legibility.

Issue #103

Description

This PR updates the VideoSegmentGeneratorAppliance to use the new origin Payload.

This also involved renaming some internal variables and methods so the term origin wouldn't be overloaded.

Note that it's hard to name variables that exist to resolve two separate time frames that are moving forward in parallel... but I do think these names are an improvement.

Related Issues

Related to #103