search

tvkitchen / appliances

A one stop shop for official TV Kitchen Appliances
GNU Lesser General Public License v3.0
3 stars 0 forks source link

VideoCaptionExtractorAppliance stops generating captions #112

Closed slifty closed 3 years ago

slifty commented 3 years ago

Bug

Current Behavior

After some amount of time the caption extractor stops generating captions. At first I thought this was due to #111 (and indeed that may cause some problems), but I noticed it happen even when the position is still incrementing.

My current theory is that the ccextractor process is spawned in a way that does NOT mark stderr as ignore, and that stream is not actually consumed by anything. This happened before with ffmpeg in #53 and simply passing a stdio config during the spawn solved that nicely.

We can do that here, though It might also be valuable to pipe stderr to the logger with a DEBUG log level (this actually might be true for ffmpeg appliances as well), since I could imagine that output would be useful in debug situations.

I'm going to run another overnight test and see what happens.

slifty commented 3 years ago

When the error stream is consumed / output this disappears.

So yes, the fix will either be to set stderr to ignore or to consume the output of stderr and route it to the logger.