tvkitchen / appliances

A one stop shop for official TV Kitchen Appliances
GNU Lesser General Public License v3.0
3 stars 0 forks source link

SRTs sometimes roll across text #139

Open slifty opened 3 years ago

slifty commented 3 years ago

Bug

Current Behavior

Sometimes SRT buffers seem to write over the previous line, instead of starting from scratch:

image

I originally thought this was a symptom of the improvement need described in #133, but upon looking closer, it's clear that there are two sentences being merged together:

GROUP THAT WENT FROM THE PRESS
BRIEFING WHERE THEY MET BEFORE

Expected Behavior

It shouldn't merge sentences like that! Some buffer somwhere clearly needs to be cleared out.

Possible Solutions

It is possible this is related to timestamp / positions being out of order. I believe that the CCExtractor payloads may calculate positions based on the CCExtractor outputs instead of the payloads.

I suspect this is not a CaptionExtractorAppliance bug but rather an SrtGeneratorAppliance bug.

Related Issues

Possibly related to issue #133 Possibly related to the fix for #130, as that was a recent change that impacted calculated positions.