tvkitchen / appliances

A one stop shop for official TV Kitchen Appliances
GNU Lesser General Public License v3.0
3 stars 0 forks source link

Payloads generated by caption extractor have the wrong data type #72

Open slifty opened 3 years ago

slifty commented 3 years ago

Bug

The ccextractor appliance currently generates payloads that have data of type string, but the Payload documentation specifies that payloads are of type Buffer.

There are two possible fixes:

1) Wrapping the data in Buffer.from

2) Updating the buffer documentation to say it is either a buffer or a string, depending on the payload type.

I believe the current Avro payload definition allows for bytes or strings, so it should be adjusted if we decide to not allow strings.

If we do wrap in a buffer, we may need to update appliances that consume caption payloads right now to properly convert from buffer to string.