Fix message ordering - Githubissues

tvkitchen / countertop

The entry point for developers who want to set up a TV Kitchen.

https://tv.kitchen

GNU Lesser General Public License v3.0

6 stars 2 forks source link

Fix message ordering #111

Closed slifty closed 3 years ago

slifty commented 3 years ago

Description

This PR fixes CountertopWorker so that it will not write to Kafka until the previous payload has been processed.

Due Diligence Checklist

[x] Tests
[x] Documentation
[x] Consolidated commits
[x] Relevant labels assigned
[x] Changelog(s) updated

Steps to Test

yarn test

Deploy Notes

None

Related Issues

Resolves #110

slifty commented 3 years ago

Merging this without approval despite the critical bug it introduces. Also creating an issue to reflect that memory leak.

The reasoning for this terrible terrible choice is that I don't think the memory leak will cause critical failure at this stage in the project's life, whereas the out of order payloads will. That being said, we have to fix the memory leak before we can say this is a tool that others can use.