search

tvkitchen / countertop

The entry point for developers who want to set up a TV Kitchen.
https://tv.kitchen
GNU Lesser General Public License v3.0
6 stars 2 forks source link

Fix the memory leak caused by events #115

Closed slifty closed 3 years ago

slifty commented 3 years ago

Task

Description

As mentioned (and created) in #111, Payloads are passed from the appliance to the CountertopWorker via events, which have no mechanism to communicate backpressure.

We need to either:

  1. Use the temporary approach suggested by @chriszs which allows the event to pass a callback.
  2. Implement the pipeline architecture for appliances discussed in [https://github.com/tvkitchen/meta/issues/17]

Relevant Resources / Research

slifty commented 3 years ago

Now that we have closed out #119 I believe the memory leak is gone (backpressure is now handled by kafka / kafka won't pass data if things are blocked up in the appliances)