tvkitchen / countertop

The entry point for developers who want to set up a TV Kitchen.
https://tv.kitchen
GNU Lesser General Public License v3.0
6 stars 2 forks source link

Resolve warning about ESLint's React hooks #17

Closed reefdog closed 4 years ago

reefdog commented 4 years ago

Task

Description

When I run yarn install, I get the following warning:

warning " > eslint-config-airbnb@18.0.1" has unmet peer dependency "eslint-plugin-react-hooks@^1.7.0".

Doing some research, it seems just adding the eslint-config-airbnb is insufficient for its default configuration, which includes React linting; we also have to install a series of dependencies that for some reason aren't picked up automatically.

We won't be using React in this repo, so we have two choices:

  1. Switch to the eslint-config-airbnb-base package that excludes the React-related dependencies
  2. Continue to use this one, but add the installation of the additional dependencies to our install instructions (npx install-peerdeps --dev eslint-config-airbnb)

I prefer №1, though the argument for №2 is keeping a consistent set of requirements and install steps for when we do want to use React.

Relevant resources / research

Related Issues

No related issues, though we added ESLint in PR #11.