search

tvkitchen / countertop

The entry point for developers who want to set up a TV Kitchen.
https://tv.kitchen
GNU Lesser General Public License v3.0
6 stars 2 forks source link

Fix test coverage and linting #171

Closed slifty closed 2 years ago

slifty commented 2 years ago

This PR fixes our test coverage reporting to include files that don't have tests. It also makes sure we're explicitly using airbnb-base linting rules.

codecov[bot] commented 2 years ago

Codecov Report

Merging #171 (eccc30f) into main (2f4c8fe) will decrease coverage by 1.04%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #171      +/-   ##
==========================================
- Coverage   88.51%   87.47%   -1.05%     
==========================================
  Files          22       25       +3     
  Lines         418      423       +5     
  Branches       67       67              
==========================================
  Hits          370      370              
- Misses         46       51       +5     
  Partials        2        2
Impacted Files Coverage Δ
src/tools/utils/index.ts 0.00% <0.00%> (ø)
src/classes/index.ts 0.00% <0.00%> (ø)
src/index.ts 0.00% <0.00%> (ø)

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

slifty commented 2 years ago

This makes it look like coverage went down (by 1%) but really this is just recognizing a more accurate reality because it ensures all testable files are recognized in the test coverage report.