Closed slifty closed 1 year ago
Merging #191 (1b8a77e) into main (25d4672) will decrease coverage by
1.62%
. The diff coverage is80.00%
.:exclamation: Current head 1b8a77e differs from pull request most recent head 2b50144. Consider uploading reports for the commit 2b50144 to get more accurate results
@@ Coverage Diff @@
## main #191 +/- ##
==========================================
- Coverage 88.43% 86.81% -1.62%
==========================================
Files 19 19
Lines 441 440 -1
Branches 88 82 -6
==========================================
- Hits 390 382 -8
- Misses 51 58 +7
Flag | Coverage Δ | |
---|---|---|
javascript | 98.25% <ø> (+0.99%) |
:arrow_up: |
typescript | 79.47% <80.00%> (-0.26%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Files Changed | Coverage Δ | |
---|---|---|
src/classes/Countertop.js | 93.33% <ø> (ø) |
|
src/classes/CountertopStation.ts | 78.26% <78.26%> (ø) |
|
src/classes/CountertopStream.ts | 100.00% <100.00%> (ø) |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
I think this is another case where test coverage is going to be too hard to do since we rely on Kafka and aren't mocking kafka effectively. Once Kafka is taken out of the project it will be easier to test the rest of CountertopStation.
This PR converts CountertopStation to TypeScript
Related to #153