search

tvlfrosty / Reputation_Guide

A World of Warcraft addon to help you manage your reputation and Factions.
GNU General Public License v3.0
3 stars 4 forks source link

Possible fix for 10.1.7 error #42

Closed Hyphie24 closed 1 year ago

Hyphie24 commented 1 year ago

5x ReputationGuide:RegisterEvent(): ReputationGuide:RegisterEvent(): Attempt to register unknown event "UPDATE_TRADESKILL_RECAST" [string "=[C]"]: in function RegisterEvent' [string "@ReputationGuide/ReputationGuide.lua"]:346: in functionREP_OnEvent'

Locals: (temporary) = ReputationGuide { 0 = } (temporary) = "UPDATE_TRADESKILL_RECAST"

Change line 346 in ReputationGuide.lua from REP_Main:RegisterEvent("UPDATE_TRADESKILL_RECAST")

to

REP_Main:RegisterEvent("UPDATE_TRADESKILL_CAST_STOPPED")

tvlfrosty commented 1 year ago

Thanks for posting the issue + possible sulution!

I am going to do some testing on normal server tomorrow, because I am not even sure that "UPDATE_TRADESKILL_RECAST" is needed for what it's currently used for.

Once I am done with some testing I will push an update to curseforge to at least fix the error for PTR server.

tvlfrosty commented 1 year ago

Apologies, didn't realise the 10.1.7 Patch was this close to release, I remove the RegisterEvent completely for 10.1.7 onwards, as it didn't seem to do much. I will keep monitoring things in case it causes any unwanted behaviour...

Update is currently being uploaded to Curseforge, this should fix the error.

Thanks again for reporting the issue!