search

tvraman / emacspeak

Emacspeak --- The Complete Audio Desktop
247 stars 54 forks source link

run: don't open a non-existing $& file #101

Closed Hi-Angel closed 10 months ago

Hi-Angel commented 10 months ago

It's not clear what this "$&" was for, but it results in Emacs starting via ./run script opening the $& buffer, which is not useful. So fix that.

@tvraman please, can you not remove my authorship from the commits, I'd prefer them to show up on my profile.

tvraman commented 10 months ago

typo for -- fixing. PRs created for the sake of credit will be ignored; meaningful PRs will be merged.

tvraman commented 10 months ago

Thanks for catching the typo: should have been @.***

As for "credit" and PRs on Github, if you produce a pull-request that is meaningful you'll definitely get credit, but this is a low resource project where you will be unhappy if public credit is your goal, perhaps find a more visible and more appropriate for your needs project on GH. --

Hi-Angel commented 10 months ago

As for "credit" and PRs on Github, if you produce a pull-request that is meaningful you'll definitely get credit

This is not true: that's my second PR and you always merge my changes under your name.

Can you please document that you are going to take credit for any contribution anybody sends to you? Had I been less experienced in talking to people and contributing to project that would've been very offending action to me.

if public credit is your goal, perhaps find a more visible and more appropriate for your needs project on GH.

It isn't my goal, I just want contributions to show up on my profile for any potential employer to see.

That said, with your attitude to contributors this is my last PR to this project; and if I ever talk with anyone about emacspeak, I will sure mention them to avoid sending patches unless they want their changes to end up under your name.

Thanks.