search

tvraman / emacspeak

Emacspeak --- The Complete Audio Desktop
245 stars 52 forks source link

Don't crash if mixing the play program #108

Closed robertmeta closed 7 months ago

robertmeta commented 7 months ago

TV: not sure this is the way you would want to do it, would a cl-assert and a message be a more correct approach?

robertmeta commented 7 months ago

Random aside, I made this PR using hub from eshell without touching the web interface, all from in emacs.

tvraman commented 7 months ago

not sure this is needed since if sox is not installed sox-play will be nil and the code guards against that

--

tvraman commented 7 months ago

See https://github.com/tvraman/emacspeak/blob/master/lisp/emacspeak-sounds.el#L115 for why this is likely not needed