search

tvrenamer / tvrenamer

A Java GUI utility to rename TV episodes from TV listings
http://www.tvrenamer.org
Other
152 stars 29 forks source link

Choose whether to use aired order or DVD order #261

Closed mtrolley closed 6 years ago

mtrolley commented 7 years ago

Some TV series have different aired order than DVD order (Firefly for instance). It would be nice to be able to choose whether you want the file names to come from the aired order or DVD order entries on The TVDB.

mtrolley commented 7 years ago

Sorry, I didn't search first and see there is already an open issue #169

eprenamer commented 7 years ago

@trolley Is it something you are able to work on?

mtrolley commented 7 years ago

@eprenamer I can take a look. AFAIK the official TVDB API doesn't support DVD ordering. There's another project I use on Linux though, dbr/tvnamer, that does it but they use their own Python API dbr/tvdb_api.

vipuldelwadia commented 7 years ago

TheTVDB has both "aired episode number" and "dvd episode number" (https://api.thetvdb.com/swagger#!/Series/get_series_id_episodes), and we capture this information when we query the API in TVRenamer. The issue is exposing this preference in the UI so that the user can select which ordering they want, probably on a show-by-show basis.

mtrolley commented 7 years ago

@vipuldelwadia Thank you for pointing that out. I asked for DVD ordering support on another project I use and was told it's not available. I guess I should have looked myself :)

mtrolley commented 7 years ago

I finally got a chance to look at this but see that tvrenamer still uses the TVDB API v1 which doesn't include the DVD order information. I'll look at this again once the v2 API implementation is complete, which will be soon hopefully because I think v1 is unavailable as of Oct. 1/17.

vipuldelwadia commented 7 years ago

I've got a pull request open which changes TVRenamer to use the v2 API here; https://github.com/tvrenamer/tvrenamer/pull/240

You can check that out and create your own PR on top of that for the ordering work.

eprenamer commented 7 years ago

We definitely should move forward with the v2 API (and btw great job @vipuldelwadia !) But for the record, v1 absolutely does have the DVD order information, and it is included in the 0.8 sources.

mtrolley commented 7 years ago

Interesting. I looked at the XML returned when I queried for Firefly and the DVD episode and season fields were empty.

On Sep 25, 2017, at 11:45 PM, eprenamer notifications@github.com wrote:

We definitely should move forward with the v2 API (and btw great job @vipuldelwadia !) But for the record, v1 absolutely does have the DVD order information, and it is included in the 0.8 sources.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

vipuldelwadia commented 7 years ago

Interesting, because we definitely capture that information in tvrenamer currently: https://github.com/tvrenamer/tvrenamer/blob/master/src/main/org/tvrenamer/model/Episode.java#L26

I wonder if it's now broken in the XML API, following that big outage they had a little while ago?

mtrolley commented 7 years ago

I saw that. That's where I started, trying to create a separate list of DVD seasons but found it was always empty and eventually traced it back to looking at the XML returned by the query and finding there's no DVD info in it.

vipuldelwadia commented 7 years ago

I think at this point we should just switch to the new API

eprenamer commented 7 years ago

I agree, but I don't see the relevance to the DVD ordering. Currently, when we look up a show, we download BOTH orderings. And I think we should continue to do so with the new API.

It's a matter of what we do with that information after downloading, that is really the issue. Get that right, and it won't matter which API we use (or even if we eventually move to a different provider, etc.)

BTW the sunset date has been postponed.

eprenamer commented 7 years ago

@trolley Not all shows have DVD information. What show are you looking at?

One that I know is interesting is Robot Chicken, because unfortunately it has hard conflicts between the DVD ordering and the air ordering.

mtrolley commented 7 years ago

I'm using Firefly for my testing, but I know of a handful of shows I'm using DVD ordering on:

I use Plex and set those series as DVD ordered.

On Tue, Sep 26, 2017 at 5:07 PM, eprenamer notifications@github.com wrote:

@trolley https://github.com/trolley Not all shows have DVD information. What show are you looking at?

One that I know is interesting is Robot Chicken, because unfortunately it has hard conflicts between the DVD ordering and the air ordering.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tvrenamer/tvrenamer/issues/261#issuecomment-332336452, or mute the thread https://github.com/notifications/unsubscribe-auth/ABFZS-v195KEjmrJP2ea22z9qZ21ISU9ks5smWd_gaJpZM4O-sZx .

vipuldelwadia commented 7 years ago

@trolley Firefly definitely has the DVD ordering information in the XML API - http://thetvdb.com/api/4A9560FF0B2670B2/series/78874/all/en.xml:

<Episode>
  <id>297989</id>
  <Combined_episodenumber>2.0</Combined_episodenumber>
  <Combined_season>1</Combined_season>
  <DVD_chapter></DVD_chapter>
  <DVD_discid></DVD_discid>
  <DVD_episodenumber>2.0</DVD_episodenumber>
  <DVD_season>1</DVD_season>
  <Director>|Joss Whedon|</Director>
  <EpImgFlag>2</EpImgFlag>
  <EpisodeName>The Train Job</EpisodeName>
  <EpisodeNumber>1</EpisodeNumber>
  <FirstAired>2002-09-20</FirstAired>
  <GuestStars>|Gregg Henry|Tom Towles|Andrew Bryniarski|Michael Fairman|Jeff Ricketts|Mark Sheppard|Valerie Red-Horse|Kevin Will|Lina Patel|David Reynolds|Dennis Cockrum|Eric Lange|Tawny Rene Hamilton|Michelle Ferrara|Drew Goddard|</GuestStars>
  <IMDB_ID>tt0579539</IMDB_ID>
  <Language>en</Language>
  <Overview>Serenity continues to travel through space conducting illegal runs across the star system, which is under the control of The Alliance. A powerful and fearsome mobster named Adelei Niska demands that the crew of Serenity pull a train robbery. The train is carrying medical supplies for a community, and Reynolds and Zoe get held on suspicion. They get free with Inara's help but realize they were tricked and try to return Niska's money. His henchman isn't too happy, but Mal &quot;persuades&quot; the next guy to take the money back. Meanwhile, two blue-handed, black-suited operatives close in on River.</Overview>
  <ProductionCode>1AGE01</ProductionCode>
  <Rating>8.1</Rating>
  <RatingCount>149</RatingCount>
  <SeasonNumber>1</SeasonNumber>
  <Writer>|Tim Minear|Joss Whedon|</Writer>
  <absolute_number>2</absolute_number>
  <filename>episodes/78874/297989.jpg</filename>
  <is_movie>0</is_movie>
  <lastupdated>1458047554</lastupdated>
  <seasonid>15791</seasonid>
  <seriesid>78874</seriesid>
  <thumb_added></thumb_added>
  <thumb_height>225</thumb_height>
  <thumb_width>400</thumb_width>
</Episode>
mtrolley commented 7 years ago

I’ll try again, thanks.

On Sep 26, 2017, at 5:58 PM, Vipul Delwadia notifications@github.com wrote:

@trolley Firefly definitely has the DVD ordering information in the XML API - http://thetvdb.com/api/4A9560FF0B2670B2/series/78874/all/en.xml:

297989 2.0 1 2.0 1 |Joss Whedon| 2 The Train Job 1 2002-09-20 |Gregg Henry|Tom Towles|Andrew Bryniarski|Michael Fairman|Jeff Ricketts|Mark Sheppard|Valerie Red-Horse|Kevin Will|Lina Patel|David Reynolds|Dennis Cockrum|Eric Lange|Tawny Rene Hamilton|Michelle Ferrara|Drew Goddard| tt0579539 en Serenity continues to travel through space conducting illegal runs across the star system, which is under the control of The Alliance. A powerful and fearsome mobster named Adelei Niska demands that the crew of Serenity pull a train robbery. The train is carrying medical supplies for a community, and Reynolds and Zoe get held on suspicion. They get free with Inara's help but realize they were tricked and try to return Niska's money. His henchman isn't too happy, but Mal "persuades" the next guy to take the money back. Meanwhile, two blue-handed, black-suited operatives close in on River. 1AGE01 8.1 149 1 |Tim Minear|Joss Whedon| 2 episodes/78874/297989.jpg 0 1458047554 15791 78874 225 400 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.
eprenamer commented 6 years ago

I'm resolving this in #294 . When there are conflicting episodes for DVD and over-the-air, the cell in the table will become an inline combo-box. The default will be the DVD ordering, but the user can choose the over-the-air ordering.

There's still a lot that users could want. The UI does not explicitly tell you which is which; it just gives you both options. There is no way to change the default. Not on an overall basis, not on a per-show basis, not at all. DVD is always the default, as of this PR. But it does give users the option.