tvt2410 / google-api-php-client

Automatically exported from code.google.com/p/google-api-php-client
Apache License 2.0
0 stars 0 forks source link

Drive API: Should send { } instead of [ ] in POST body for empty objects. #246

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
For example:
$driveService->files->update("xyz", new Google_DriveFile());

Sends [ ] as the POST body. I think it should send { }

It seems this doesn't actually cause a problem on the server side, but { } 
would be the correct JSON empty object.

Possible fix:

http://code.google.com/p/google-api-php-client/source/browse/trunk/src/service/G
oogle_ServiceResource.php#93

-           ? json_encode($parameters['postBody'])
+           ? json_encode((object) $parameters['postBody'])

Original issue reported on code.google.com by dar...@google.com on 10 Jan 2013 at 9:38

GoogleCodeExporter commented 9 years ago
Silvano, in case you have any thoughts on this one.

Original comment by ianbar...@google.com on 22 Mar 2013 at 4:43

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
This issue isn't specific to the Drive API. It applies to any API.  I just used 
Drive as an example.

Original comment by dar...@google.com on 22 Mar 2013 at 4:57

GoogleCodeExporter commented 9 years ago

Original comment by ianbar...@google.com on 28 Mar 2013 at 5:20

GoogleCodeExporter commented 9 years ago
This issue tracker is now closing. Development on the Google PHP client library 
moved to GitHub with the release of the 1.0.0-alpha, and now the 1.0 branch has 
reached beta status there will be no further releases of the 0.6 branch of the 
library. 

Please take a look at the latest version on 
https://github.com/google/google-api-php-client

For information on migrating, please take a look at this guide: 
https://developers.google.com/api-client-library/php/guide/migration

For general library support please ask a question on StackOverflow: 
http://stackoverflow.com/questions/tagged/google-api-php-client

If you are looking for support with a specific API, please contact the team 
working with that API via StackOverflow or their preferred support mechanism. 

If your issue still exists with the new version of the library, please raise a 
bug in the GitHub issue tracker with a minimal code sample. 

Thanks!

Original comment by ianbar...@google.com on 22 Jan 2014 at 4:53