Assignment 2 Review

[jayvenn]

👍 Nice work. The primary challenge of this homework was to learn how to use UITableView to manage a complex form, establish communication between view controllers, and apply the correct Auto Layout constraints to build adaptive UI's that work across many different screen sizes and orientations. If you haven't already, we recommend going back and running your homework again while rotating the device / simulator to ensure your AutoLayout constraints function as expected.

Grading Summary:

• Functionality: Excellent
• Code Style: Very Good
• Visual Design: Very Good

Overall: Very Good

Detailed Notes

• I like that you are using extensions
• I like that the business view controller and the filters view controller are connected via FiltersViewControllerDelegate
• Good job on most of the the auto-layouts
• Detail view's image cover text
• If you would like to step your Swift by learning about access control, I got for you this link right here.
• If you could add a suffix to all of the properties below, that would make it clear you are referring to (i.e nameLabel instead of name)
• The subviews inside the business cell should be private and only updated in the Swift property observer
• I like that you represent the Yelp Filters using custom Model classes. Makes the filters easier to work with and reuse throughout your app.
• If you ever feel lazy about creating a custom form, feel free to check out this link here.
• I like that you animate the dropdown of expandable filter settings.
• Overall, I enjoyed reading your code. If you could take a look at Access Control, then that'd be great. Nice work!

[tvtruong3964]

Hello, Thank you very much for your review and your guide to make my app better. I learned alot from your review. Thank you