fix try_reduce_out_degree: don't reverse irreversible edges

tvwenger / maxfield

An Ingress Linking and Fielding Strategy Generator

http://www.ingress-maxfield.com/

GNU General Public License v3.0

107 stars 58 forks source link

fix try_reduce_out_degree: don't reverse irreversible edges #3

Closed mvinni closed 8 years ago

mvinni commented 8 years ago

try_reduce_out_degree is eager to reverse edges without any regards to whether an edge under consideration is actually reversible. The occasional result of this is that a link in the generated plan cannot be made, because the source portal is inside a field. An example of such a bad plan is shown below (the plan suggests four successive bad links). screenshot - 2016-03-06 15-24-11

This bug comes from upstream.

tvwenger commented 8 years ago

Nice find, thanks for submitting the pull request!

mvinni commented 8 years ago

Yay, thank you! On to testing other suggestions a bit more...