twVolc / PyCamPermanent

Permanent PiCam (SO2) installation project software
GNU General Public License v3.0
2 stars 2 forks source link

Spectra reverts to default "Villarrica" on processing DOAS #116

Closed tpering closed 4 months ago

tpering commented 7 months ago

Select spectra etc: image

Click OK:

image

Something unusual going on?

image

twVolc commented 6 months ago

I think this is just an error in the messages rather than it not working. the message jumps back to the old file then to what you've set so the final result should be that it's using the spectra directory requested. I remember seeing this when I fixed the previous bug related to it and deciding it wasn't causing any issues, it just looks a little confusing when readin the messages. I think it was more hassle than it was worth to fix the mesages so I just left it for now. I'll keep this open but remove the priority label as I'm pretty sure the processing under the hood works as we want (can be checked by looking for hot pixels in the dakr spectra - they change when loaidng in a new dark spectra folder relative to the default).

ubdbra001 commented 4 months ago

What's happening here more specifically is that:

  1. When the settings window is opened it will print the current value for the Dark spectra directory. I assume that this was from a fresh start, so that would be whatever is in the default config file (.\pycam\tests\test_data\test_spectra\)
  2. Then when you press okay it will update the value for the Dark spectra directory, and then print the updated value.

As Tom said it'll be a bit of a pain to stop this behaviour as both parts are accessing the same function, and the way it is structured it's not easy to tell this function to only print the value in the second case.