twVolc / PyCamPermanent

Permanent PiCam (SO2) installation project software
GNU General Public License v3.0
1 stars 2 forks source link

Create parent class for `DoasWorker` and `IfitWorker` that holds common features #136

Closed ubdbra001 closed 3 weeks ago

ubdbra001 commented 1 month ago

As title.

ubdbra001 commented 1 month ago

Some common methods: reset_stray_pix() stray_corr_spectra()

twVolc commented 1 month ago

Just to add, in reality the vast majority of methods in these classes should be duplicates - I just haven't managed to keep on top of maintaining DOASWorker to a useable state. In an ideal world really the only method that would differ across the two is process_doas() and then also some related helper methods that might do things inside process_doas(). Also the light dilution correction aspects are reliant on iFit, so these won't be present in DOASWorker. Beyond these two big areas there should be a huge amount of common ground in the classes.