Merging updates for 2023.12 release

twVolc / PyCamPermanent

Permanent PiCam (SO2) installation project software

GNU General Public License v3.0

1 stars 2 forks source link

Merging updates for 2023.12 release #86

Closed ubdbra001 closed 7 months ago

ubdbra001 commented 8 months ago

Checklist for merging:

[x] Added options to load and save yaml config file (Closes #18, #26, #41)
[x] Add option to set which config is loaded on startup (Closes #70)
[x] Add flow nadeau (Closes #20)
[x] Generate calibration fit statistics (Closes #16)
[x] Add ability to load pre-computed calibration fit statistics
[x] Added ability to shift spectra and to manually set an LDF for processing spectra (Closes #62)
[x] Fixes #27
[x] Fixes #68
[x] Fixes #79
[x] Fixes #64
[x] Fixes #87
[x] Fixes #3
[x] Fixes #43
[x] Fixes #104
[x] Fixes #105
[x] Remove unused files
[x] Final checks to ensure result consistency

ubdbra001 commented 7 months ago

I'll run the tests today/tomorrow just to make sure the results being produced are consistent with previous versions (I don't see any reason why they should have changed), and as part of that I can see what's happening with the fixed FOV work. I'll let you know if I think it'll take longer than the end of this week, and you can decide wether it's worth delaying to fit it in this merge.

I'll take a look at the merge conflicts later today, and drop you a message if I need any advice on resolving them, but it sounds like ti should be reasonably straightforward.

twVolc commented 7 months ago

Very small tidying thing prior to this merge - in the config file could ambient_roi be moved to be part of the # Plume background model section of the file? Perhaps directly below bg_mode. It can be used in light dilution too, which is probably why I put it there in the first place, but I think it will be more clear to users if it's in the # Plume background model section.

ubdbra001 commented 7 months ago

Very small tidying thing prior to this merge - in the config file could ambient_roi be moved to be part of the # Plume background model section of the file? Perhaps directly below bg_mode. It can be used in light dilution too, which is probably why I put it there in the first place, but I think it will be more clear to users if it's in the # Plume background model section.

I was going to suggest that you should maybe have a look and reorder the parameters in the config file so that they are grouped in the most appropriate way. I'm happy to do this if you like, but it should be just a matter of moving them around in the processing_setting_defaults.yml file, as the config structure is derived from there.

twVolc commented 7 months ago

Ok great, I can have a look at this then.