twVolc / PyCamPermanent

Permanent PiCam (SO2) installation project software
GNU General Public License v3.0
2 stars 2 forks source link

Cal_series_path_fix #88

Closed ubdbra001 closed 10 months ago

ubdbra001 commented 10 months ago

Small fix to make sure that load_cal_series is only called when the calibration type is set accordingly

twVolc commented 10 months ago

Worth double checking whether things stay working if the cal_type_int is manually changed in the settings frame - will this then load things even if the cal_series_path isn't directly changed at that time. Only thinking this as the loading is done directly through setting the path, so we just need to make sure that loading also occurs if the path doesn't change. Presumably it does - if it doesn't this would be a bug not related to your change here but related to my earlier work on this...

ubdbra001 commented 10 months ago

I think this works as expected, but I'll describe what it does and you can see if you agree:

I can't think of any other use cases, but if you have something in mind not covered here then let me know and I'll give it a test.