twVolc / PyCamPermanent

Permanent PiCam (SO2) installation project software
GNU General Public License v3.0
2 stars 2 forks source link

Potential dead code that could be removed #97

Open ubdbra001 opened 10 months ago

ubdbra001 commented 10 months ago

Just collecting instances of code that look to be unused, and could potentially be removed.

ubdbra001 commented 10 months ago

I think this section may be superceded by the save_calibration() function?

https://github.com/twVolc/PyCamPermanent/blob/65e87a45b12c0493712c249e46eb48bb03aaa4ed/pycam/so2_camera_processor.py#L2283-L2296

ubdbra001 commented 10 months ago

I think all the info recorded in processing_settings.txt is now either in the config or saved in other files with the config?

https://github.com/twVolc/PyCamPermanent/blob/65e87a45b12c0493712c249e46eb48bb03aaa4ed/pycam/so2_camera_processor.py#L3855-L3867

twVolc commented 10 months ago

Yep, I'm pretty sure both are redundant now!