search

twaddington / django-gravatar

Essential Gravatar support for Django. Features helper methods, templatetags and a full test suite!
MIT License
149 stars 33 forks source link

Python 3 compatibility #13

Closed synasius closed 11 years ago

synasius commented 11 years ago

The following set of commits add python3 support without breaking backwards compatibility.

twaddington commented 11 years ago

This looks fantastic, thanks for the contribution!

twaddington commented 11 years ago

Awesome, I'm going to merge this in tonight and I'll try it out. If all looks good I'll get it uploaded to PyPi.

synasius commented 11 years ago

Awesome, I'm going to merge this in tonight and I'll try it out. If all looks good I'll get it uploaded to PyPi

:+1: and thnx for merging

synasius commented 11 years ago

also i suggest you to add python 3 classifiers in your setup.py so people will know that you support python3: 

classifiers=[
    ...
    "Programming Language :: Python :: 2.7",
    "Programming Language :: Python :: 3.3",
    ...
],
twaddington commented 11 years ago

Thanks, I'll do that tonight. Although if you felt like adding them yourself I wouldn't mind either.

twaddington commented 11 years ago

@synasius thanks for your contribution. I made some additional tweaks to .travis.yml to ensure tests were being run on Python 2.6, 2.7, 3.2 and 3.3. It's up on PyPi now as version 1.1.2.