Code Lab Feedback - Githubissues

twadeus commented 8 years ago

Hey @chrisvfritz, can you take a look at this? It's hosted here and meets the following project criteria:

[x] Include a button that will display a silly, but tasteful joke in an alert when clicked
[x] Return no errors (warnings are OK) when the HTML is uploaded to the W3C Markup Validation Service
[x] Return no errors or warnings when the JavaScript is pasted into JavaScript Lint

chrisvfritz commented 8 years ago

It works! 😄 It doesn't pass W3C Markup Validation though. Try checking out the example HTML here, comparing it to your first 3 lines especially. Beyond that, I also see an empty <script></script> element which is also outside of both the head and body.

To clarify, no elements should ever exist outside both the <head> and <body>, except for the doctype and html elements. Additionally, if we're not going to put any JavaScript in a script element, we should just delete it.

Let me know if that makes sense! Also let me know when you fix these errors, so I can take another look. 😃 🎈

twadeus commented 8 years ago

Sorry forgot to update GitHub.

chrisvfritz commented 8 years ago

Oh, much better! 🎉 🚀 :shipit: 😸

twadeus / codelab-js-intro

Code Lab Feedback #1