search

twallema / pySODM

Simulating and Optimising Dynamical Models in Python 3
Other
9 stars 2 forks source link

'samples_dict' in a draw function, 'samples' in simulation function #62

Closed twallema closed 3 months ago

twallema commented 1 year ago

A draw function is defined as follows,

def draw_function(param_dict, samples_dict):
    return param_dict

The argument samples_dict is passed from the sim function, where it is named samples. I suggest renaming samples_dict to samples and param_dict to parameters for uniformity.

twallema commented 3 months ago

Partly addressed in PR #73 . To be further generalized.

twallema commented 3 months ago

Fully generalized in PR #75 Closing this issue