Closed dentarg closed 5 years ago
Sure -- I can't get to this right now, but PRs are welcome - or I can probably look at it over the weekend.
@twalpole do you have any opinions/ideas on how to solve it? should we use the :timeout
value instead of the hardcoded value?
@dentarg Yeah - using the timeout value probably makes the most sense.
@dentarg Sorry - this has taken me longer than expected to get around to. As a temporary fix I've changed this to 30 seconds and pushed it to master. Hopefully I'll get to making it configurable sometime in the next week.
This has been delayed as I've been working on reworking a lot of things to cleanup and simplify the code.
Hi, thanks for a great gem!
Would it be possible to make the
expire_in
value sent toCapybara::Helpers.timer
inwait_for_loaded
configurable?https://github.com/twalpole/apparition/blob/3dddbbd5e66fde2186ff3b53612dbe55a6149bba/lib/capybara/apparition/page.rb#L232-L233
The README says that it is possible to use
:timeout
(and that default is 30 seconds), but I was consistently getting the error below until I went into the apparition directory in~/.gem/
and raisedexpire_in
. I could also see that my test never ran for 30 seconds, it was always somewhere around 15 seconds.(I'm loading a page from the internet, not an app running locally, so that's why I would like to give everything some more time.)