twalpole / apparition

Capybara driver for Chrome using CDP
MIT License
363 stars 46 forks source link

add all of the filenames and paths that chromedriver searches for #15

Closed titusfortner closed 5 years ago

titusfortner commented 5 years ago

This is the same code I'm proposing for webdrivers based on the logic I parsed from chromedriver's finder code, except that this project is also searching on PATH as a fallback. I didn't add find_first_binary(file) to #windows_path because I assumed there was a reason you weren't already using it (though that reason isn't obvious to me looking at the code).

twalpole commented 5 years ago

The only reason I didn't have find_first_binary on windows was because I didn't have anything on windows (was hoping someone else would handle it :) ) - thanks for this