search

twalpole / apparition

Capybara driver for Chrome using CDP
MIT License
363 stars 46 forks source link

Fix `browser.set_proxy_aauth` typo? #19

Closed baffers closed 5 years ago

baffers commented 5 years ago

Hello! I got real into the weeds of apparition today (isn't javascript just the best?) and noticed something that might be a typo... I couldn't find any methods that matched on set_proxy_aauth, however, there is a method set_proxy_auth that seemed more ... fitting.

Anyway, it didn't look like there was any test coverage. I'm happy to add some but I'm not sure what would be most impactful so I'm open to suggestions! If this wasn't a typo, then let's close this PR and pretend like it never happened.

twalpole commented 5 years ago

Definitely a typo -- There are some tests around proxy stuff in the capybara-webkit portion of the specs - https://github.com/twalpole/apparition/blob/master/spec/capybara-webkit/driver_spec.rb#L3076 - but the capybara-webkit tests aren't run by default (bundle exec rspec cw), and the proxy tests specifically are skipped currently due to not being fully converted yet.

Thanks for this!

baffers commented 5 years ago

Thank you for all your hard work!