Closed volodymyr-mykhailyk closed 4 years ago
Still trying to figure out why all the tests are failing on Travis while working locally
Hi @twalpole, I will probably need your help figuring out why majority of tests are failing right now. I tried running the tests on the latest master without my changes - results are the same.
@volodymyr-mykhailyk master should run tests again. The linux distribution specified in .travis.yml was no longer receiving the latest chrome. Please rebase.
@twalpole Thanks. I will update the branch.
In the background - I tried migrating to GitHub Actions and have running build. Are you interested in such a change? Can submit another PR
@volodymyr-mykhailyk Re: Github actions - To what benefit? If there is a decent benefit to using Github actions then possibly, but I'm not interested in moving to Github actions just because it's new.
@twalpole No particular benefit. GitHub build runners just have more software installed including latest chrome. Tried this out to make sure problem not in my code.
Back to this PR. Changes are ready, except few more failing tests unrelated to the change. Please let me know how I should proceed.
As part of this PR also included two changes
Looking into the additional fails - figured that wait_for_loaded
method could cause similar issues as in selenium driver I was fixing recently. Is there a reason why you are not using Document.readyState to detect when the page and DOM is loaded?
@volodymyr-mykhailyk Because the whole concept of "is loaded" is poorly defined - and every method used has pros and cons
@twalpole Added your recent Rubocop changes to my branch. Changes are ready, except few failing tests unrelated to the change. Please let me know how I should proceed. Thanks
Other than my caution around the pausing code, which I need to test on multiple platforms - could be please fix the conflict that currently exits. Thanks
Other than my caution around the pausing code, which I need to test on multiple platforms - could be please fix the conflict that currently exits. Thanks
I understand. This fix was really not needed as part of this PR. Skipped two unrelated commits to the change. If you will even have problem with the pause method - feel free to ping me, I can try to help.
Thanks
Extend
Launcher
with an option to connect to existing Chrome instance instead of starting Chrome on the local host.This is useful if tests are running in the CI environment and instead of installing Chrome into Docker/Host - CI launching prebuilt chrome image and Apparition using it.
Additional items:
ChromeClient
hasget_ws_url
function not used anywhere. Duplicated it inRemote
launcher because I wasn't sure about an original method purpose.