twalpole / apparition

Capybara driver for Chrome using CDP
MIT License
363 stars 46 forks source link

Initialize ChromeClient timeout with default Capybara timeout #85

Open francisbeaudoin opened 3 years ago

francisbeaudoin commented 3 years ago

When using session.visit(), if the page includes indefinitely running Javascript, apparition hangs and never timeouts.

To reproduce the issue, create an HTML page having the following code and session.visit it:

<script>
    while(true) { }
</script>

Observe apparition hanging indefinitely.

To fix the problem, I'm initializing the ChromeClient with the session_wait_time value.