search

twalpole / apparition

Capybara driver for Chrome using CDP
MIT License
363 stars 46 forks source link

Google Chrome quit unexpectedly. #9

Closed skyeagle closed 5 years ago

skyeagle commented 5 years ago

Thanks for the fantastic gem!

Everything looks fine except one thing. Chome periodically crashes at the end of the process of running specs and Mac creates a crash report.

The issue does exist for non-headless mode on Mac. I tried to debug it and seems like Chrome's process gets killed before a proc of process killer gets executed.

A simple repro is to run this spec in non-headless mode (I've changed it to false in spec/spec_helper.rb)

rspec spec/capybara-webkit/driver_rendering_spec.rb:50

Any ideas of how it could be fixed? I'd love to help and provide any needed info.

Thanks in advance!

twalpole commented 5 years ago

Unfortunately I can't replicate this with Chrome 73.0.3683.103 on macOS 10.14.4 . Is that the same as you're using? Are you using the current master branch?

twalpole commented 5 years ago

Ok - It replicates now - not really sure what we can do about it - the process just isn't ending when told to sometime - even if I increase KILL_TIMEOUT to a much larger value Chrome appears to ignore the TERM signal sometimes and then eventually gets force killed - I'm open to any ideas

twalpole commented 5 years ago

@skyeagle Ok - fixed it - It was sending the wrong signal to Chrome to fully shut it down. Please give the master branch a try now.

skyeagle commented 5 years ago

@twalpole it worked, awesome! blazing fast fix, thank you so much for such exciting work!