twarne / xebia-france

Automatically exported from code.google.com/p/xebia-france
0 stars 0 forks source link

Need to support multiple XFF headers #2

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
I've noticed that if my proxy appends an extra XFF header as opposed to
simply appending to existing XFF header that the valve does not take
multiple XFF headers into account.

Am testing against Apsis Pound as a load balancer / proxy and it adds an
extra XFF header as opposed to simply appending to an existing one.

Original issue reported on code.google.com by ebenza...@gmail.com on 27 Nov 2009 at 8:47

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
Indeed, Apsis Pound seems to not follow the behavior described in Wikipedia
X-Forwarded-For (1) and implemented in Squid, Apache Httpd, F5 Big-IP, etc.

I am sorry but I prefer to stick to the official behavior described in Wikipedia
rather than increasing code complexity, risking bugs and performance 
degradation for
this.

Maybe you could propose the Apsis Pound to enhance their handling of 
x-forwarded-for
header (line 1055 of file http.c for Pound 2.4.5). There are interesting ideas 
in
Apache Httpd mod_proxy_http.c (2). Another approach is to customize the java 
code.

(1) http://en.wikipedia.org/wiki/X-Forwarded-For
(2)
http://fisheye6.atlassian.com/browse/httpd/httpd/trunk/modules/proxy/mod_proxy_h
ttp.c?r=790587#l819

Original comment by cyrille....@gmail.com on 29 Nov 2009 at 11:46