Closed muandrew closed 4 years ago
I plan on adding two more changes.
All rules have checked completely. Start to unzipping.
--silent
flag where the default behavior is to print log messages or
a --verbose
flag where the default behavior is to not print log messages. Let me
know what you prefer.@muandrew
Thank you very much for your help and the pull request. It looks good to me. Once you have done these changes, I will merge this and then update it to PyPi package.
I plan on adding two more changes.
- add an output directory option
- add a --silent or --verbose flag.
- right now your library outputs
All rules have checked completely. Start to unzipping.
- I will either add a
--silent
flag where the default behavior is to print log messages or a--verbose
flag where the default behavior is to not print log messages. Let me know what you prefer.
--verbose seems better 😄
Thank you very much for making sunzip better!
Merging #3 into master will not change coverage by
%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #3 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 6 6
=========================================
Hits 6 6
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 5f02040...51484a2. Read the comment docs.
The changes are ready for review. After this PR I will open another change, see muandrew:amu_exception. I have made deeper changes to the class's expected behavior so I didn't want to bundle it up into this PR. I would also like to change your class name sunzip
to Sunzip
in a separate change if you don't mind.
Thanks!
Thanks for this Pull Request, nice work. LGTM
The changes are ready for review. After this PR I will open another change, see muandrew:amu_exception. I have made deeper changes to the class's expected behavior so I didn't want to bundle it up into this PR. I would also like to change your class name
sunzip
toSunzip
in a separate change if you don't mind.Thanks!
sounds great! Thanks
I don't know how you would like your PRs (Pull Requests) to be structured. I can take each commit and make them a stand alone PR or you can take this one.
remove .DS_Store
is pretty simple just updating.gitignore
.migrate to pythong-packaging...
is pretty straightforward also. I have also avoided pulling in any dependencies[cli] add arguments that ...
probably requires more review.man unzip
which may collide if I used some of the one character ones.sunzip
I would recommend consolidating that. One example of this isthreshold
vscompression-ratio
.