search

twbgc / sunzip

Provide secure unzip against zip bomb :bomb:.
https://pypi.org/project/sunzip/
GNU General Public License v3.0
36 stars 8 forks source link

Change exception handling, change class name #4

Closed muandrew closed 4 years ago

muandrew commented 4 years ago

Let users of the library catch and handle exception themselves instead of bailing. Let cli catch and exit 1 to signify error Change class name to be capitalized to make distinct from modules and variables

codecov-io commented 4 years ago

Codecov Report

Merging #4 into master will not change coverage by %. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master        #4   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            6         6           
=========================================
  Hits             6         6

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3d1afdb...444583a. Read the comment docs.

muandrew commented 4 years ago

Thanks for reviewing the last PR so quickly!

If I find anything that could use improvement I'll be back to make more PRs.

muandrew commented 4 years ago

force pushed to update readme

krnick commented 4 years ago

Awesome! Thank you for the great work, I will move on updating to PyPi package.

muandrew commented 4 years ago

Thanks again for the review!