search

twbs / bootlint

HTML linter for Bootstrap projects
MIT License
2.4k stars 313 forks source link

Update cheerio to v1.0.0-rc.3. #457

Closed XhmikosR closed 4 years ago

XhmikosR commented 5 years ago

This is something I can't figure out. While tests here pass fine, they break on grunt-bootlint

https://github.com/twbs/grunt-bootlint/commits/xmr-cheerio-test

If anyone has any ideas please let me know.

XhmikosR commented 5 years ago

Any ideas @Johann-S? https://github.com/twbs/grunt-bootlint/tree/xmr-cheerio-test see how tests fail there

Johann-S commented 5 years ago

Not sure but in test/fixtures files there are a lot of missing files included 🤔

XhmikosR commented 5 years ago

@Johann-S I think this is the cause https://github.com/cheeriojs/cheerio/compare/0.22.0...v1.0.0#diff-e1bbd4f15e3b63427b4261e05b948ea8R24

It just that happens to be triggered on grunt-bootlint, but we need to think how to proceed here.