search

twbs / bootstrap-npm-starter

Starter template for new building with Bootstrap 4 in npm projects.
MIT License
1.23k stars 465 forks source link

Update start.scss to conform to bootstrap 5.1 instructions #65

Closed djKianoosh closed 2 years ago

djKianoosh commented 3 years ago

Following the instructions here: https://getbootstrap.com/docs/5.1/customize/sass/#variable-defaults

Moved the functions import first, to avoid $theme-colors "isn't a valid CSS value" https://stackoverflow.com/q/68909199/573389

XhmikosR commented 3 years ago

Thanks but this will be fixed in #49

djKianoosh commented 3 years ago

Cool that's good to know. That's why I targeted the v5 branch.

XhmikosR commented 3 years ago

Actually, wait. If this is targeting the v5 branch it might still be valid. /CC @mdo

djKianoosh commented 3 years ago

The key line from the docs is

Variable overrides must come after our functions are imported, but before the rest of the imports.

which I also added in a comment so it's not missed. That seems to be the difference.