search

twbs / bootstrap-sass

Official Sass port of Bootstrap 2 and 3.
http://getbootstrap.com/css/#sass
MIT License
12.59k stars 3.53k forks source link

Deprecation warnings with `Dart Sass 1.33.0` #1217

Closed boris-petrov closed 2 years ago

boris-petrov commented 3 years ago

Dart Sass deprecated the division syntax in version 1.33.0. Bootstrap uses this a lot and there are hundreds of warnings in my console. It would be nice to fix those.

Koozza commented 3 years ago

Sadly same issue here. Would love to see this fixed.

realtebo commented 2 years ago

We will end to use https://www.npmjs.com/package/patch-package

Sad but ... we need to continue use this package and do not wait so long because of 3 minutes of deprecation warnings!

Zianor commented 2 years ago

Any plans to merge the PR to fix the issue?

japick-joules commented 2 years ago

Same issue but for version 2.0.0

Deprecation Warning: Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.

OakBehringer commented 2 years ago

Considering this library hasn't had a single commit made to it in years, I'd say we're SOL

glebm commented 2 years ago

Published 3.4.2 to npm only

jordanade commented 2 years ago

@glebm Now I can't compile at all:

ModuleBuildError: Module build failed (from ./node_modules/sass-loader/dist/cjs.js):
SassError: Missing argument $number2.
  ┌──> node_modules/bootstrap-sass/assets/stylesheets/bootstrap/_variables.scss
338│ $grid-float-breakpoint-max: math.div($grid-float-breakpoint - 1) !default;
  │                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ invocation
  ╵
AprilArcus commented 2 years ago

@glebm Now I can't compile at all:

ModuleBuildError: Module build failed (from ./node_modules/sass-loader/dist/cjs.js):
SassError: Missing argument $number2.
  ┌──> node_modules/bootstrap-sass/assets/stylesheets/bootstrap/_variables.scss
338│ $grid-float-breakpoint-max: math.div($grid-float-breakpoint - 1) !default;
  │                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ invocation
  ╵

fixed in 3.4.3; sorry about that.