search

twbs / bootstrap-sass

Official Sass port of Bootstrap 2 and 3.
http://getbootstrap.com/css/#sass
MIT License
12.6k stars 3.53k forks source link

Bump Sass and migrate / to math.div() #1218

Closed TylerVigario closed 2 years ago

TylerVigario commented 3 years ago

Fix for #1217: Using / for division was recently deprecated in Sass.

I've updated the source to use math.div() and moved to Dart Sass (version 1.33).

kikyous commented 3 years ago

since this repo is no loger active maintains, i made a npm package use your pr, hope it is usefull https://www.npmjs.com/package/bootstrap3-sass https://github.com/kikyous/bootstrap3-sass

install: npm install bootstrap3-sass

JeremyCarlsten commented 2 years ago

@TylerVigario Is there a plan to merge this? Seeing it all over our projects aswell.

TylerVigario commented 2 years ago

@TylerVigario Is there a plan to merge this? Seeing it all over our projects aswell.

Use fork from @kikyous above.

szysza commented 2 years ago

@kikyous, @TylerVigario after installing the fork with the fix I'm getting the following error:

Error: Invalid CSS after "...     floor(math": expected expression (e.g. 1px, bold), was ".div($grid-gutter-w"
        on line 370 of ../../../../../../.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/bundler/gems/bootstrap3-sass-bbd592141451/assets/stylesheets/bootstrap/_variables.scss
        from line 8 of ../../../../../../.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/bundler/gems/bootstrap3-sass-bbd592141451/assets/stylesheets/_bootstrap.scss

which seems to be coming from this line. Any ideas on how to fix the issue? I'm using ruby 2.7.4 and rails in version 6.1.4.1.

kikyous commented 2 years ago

@kikyous, @TylerVigario after installing the fork with the fix I'm getting the following error:

Error: Invalid CSS after "...     floor(math": expected expression (e.g. 1px, bold), was ".div($grid-gutter-w"
        on line 370 of ../../../../../../.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/bundler/gems/bootstrap3-sass-bbd592141451/assets/stylesheets/bootstrap/_variables.scss
        from line 8 of ../../../../../../.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/bundler/gems/bootstrap3-sass-bbd592141451/assets/stylesheets/_bootstrap.scss

which seems to be coming from this line. Any ideas on how to fix the issue? I'm using ruby 2.7.4 and rails in version 6.1.4.1.

It is a npm package,not a ruby gem.

szysza commented 2 years ago

@kikyous, @TylerVigario Thanks for the quick response. npm is just a way of making the package available to use in projects. According to the README of both the forked version and the original one it's possible to use it with ruby on rails. That's they way that I'm using it in the project that I'm working on and it's causing the issue that I've described in my previous comment. Most probably I'll try to experiment with the fork locally and will try to pin point the issue. If you come up with any idea why this issue is happening then I would be grateful.

TylerVigario commented 2 years ago

@szysza math.div is available only in Dart Sass v1.33 and later. Can you confirm you are using Dart Sass with at least version 1.33?

fmeyertoens commented 2 years ago

@kikyous Thank you for forking the repo. Would you mind opening the issue tab on your repo in case of problems like this in the future?

kikyous commented 2 years ago

@kikyous Thank you for forking the repo. Would you mind opening the issue tab on your repo in case of problems like this in the future?

OK, issue tab has been opened.

@fmeyertoens

glebm commented 2 years ago

1221 was merged instead