twbs / bootstrap

The most popular HTML, CSS, and JavaScript framework for developing responsive, mobile first projects on the web.
https://getbootstrap.com
MIT License
171k stars 78.9k forks source link

IE nav-justified issue. #10649

Closed voviklenin closed 11 years ago

voviklenin commented 11 years ago

There is a problem with nav-justified when opening it in IE, the dropdown item falls 1 line lower than the rest of menu items. Works fine on mozilla and chrome.

cvrebert commented 11 years ago

What version(s) of IE?

poromaa commented 11 years ago

~~Actually I get same problem if i just resize the browser-window in chrome (29.0.1547.65) + safari (Version 6.0.5 (8536.30.1)). Even on getbootstrap.com. To replicate problem:

  1. goto http://getbootstrap.com/components/#nav-justified
  2. resize browser window width to smallest (400px in Chrome)
  3. resize it back to normal width and now all "home" tabs are above the other two tabs in the example~~
cvrebert commented 11 years ago

@poromaa That's #9774. @voviklenin's issue sounds different.

@voviklenin: Also, could you post a JSFiddle or JSBin live example of the problem?

voviklenin commented 11 years ago

The Version of Explorer is 10, I will try to post it on JSFiddle but within next week or so, little bit busy with the project.

voviklenin commented 11 years ago

Forgot to mension that I am using wordpress with wp-bootstrap-navwalker.

voviklenin commented 11 years ago

It also creates a glitch in mobile button slider, the submenu does drop down but not in smaller window on the left like in standard menu.

cvrebert commented 11 years ago

Well, we can't help with the WordPress-specific parts, but if you can create the plain JSFiddle example, then we can certainly debug that.

voviklenin commented 11 years ago

http://jsfiddle.net/voviklenin/Ctw4q/4/

voviklenin commented 11 years ago

Here is an example.

voviklenin commented 11 years ago
            <div class="row">
                <div class="col-md-12 rempd">
                    <nav class="navbar navbar-default navbar-turquoise" role="navigation">
                        <div class="navbar-header">
                                <button type="button" class="navbar-toggle" data-toggle="collapse" data-target=".navbar-ex1-collapse">
                                    <span class="sr-only">Toggle navigation</span>
                                    <span class="icon-bar"></span>
                                    <span class="icon-bar"></span>
                                    <span class="icon-bar"></span>
                                </button>
                        </div>

                        <div class="collapse navbar-collapse navbar-ex1-collapse">
                                <?php
                                    wp_nav_menu( array(
                                        'menu'              => 'nav_main',
                                        'theme_location'    => 'nav_main',
                                        'depth'             => 2,
                                        'container'         => false,
                                        'menu_class'        => 'nav nav-justified',
                                        'fallback_cb'       => 'wp_page_menu',
                                        'walker'            => new wp_bootstrap_navwalker())
                                        );        
                                ?>
                        </div><!-- /.navbar-collapse -->
                    </nav>
                </div>
            </div>
voviklenin commented 11 years ago

This is the way it was implemented. I am not sure wether the plugin bootstrap_navwalker was created by same people as the bootstrap itself.

cvrebert commented 11 years ago

@voviklenin As a member of the Bootstrap core team, I can tell you that it wasn't. We don't write any plugins for third-party stuff like WordPress.

voviklenin commented 11 years ago

http://jsfiddle.net/voviklenin/hKq5t/

It does cause trouble even if I hardwire and create the justified menu as per tutorial, has the same issue as through the plugin

lifofernandez commented 11 years ago

Hi, first, sry for my english.

I have the exact same issue here... I think the problem is not with bootstrap nor the menu waker (http://illuminatikarate.com/blog/bootstrap-walker-for-wordpress/)... before the menu there are diferences in the way wp-bootstrap code the header... check this... http://www.diffchecker.com/a1ocvp87 in that way, wp-bootstrap is not ready for nav-justified

im gona give a try on this...

cvrebert commented 11 years ago

Judging by our Justified Nav example page, I don't think we support using .justified-nav on the navbar.

lifofernandez commented 11 years ago

if you use the code inspector to replace .navbar-nav with .justified-nav in the de ul menu to the bootstrap page it seems to work fine, even in iE8 (but I dont know alrredy if its collapsing right)

mdo commented 11 years ago

We don't support the .justified-nav class within navbars at this time.