twbs / bootstrap

The most popular HTML, CSS, and JavaScript framework for developing responsive, mobile first projects on the web.
https://getbootstrap.com
MIT License
170.49k stars 78.84k forks source link

v5 docs: brand guidelines need update (and question about the brand colors explanation) #31092

Closed patrickhlauke closed 4 years ago

patrickhlauke commented 4 years ago

obviously, https://v5.getbootstrap.com/docs/5.0/about/brand/ needs to show the new logo, rather than the old one.

however, skimming over them, I also stumbled across this part https://v5.getbootstrap.com/docs/5.0/about/brand/#colors

Our docs and branding use a handful of primary colors to differentiate what is Bootstrap from what is in Bootstrap. In other words, if it’s purple, it’s representative of Bootstrap.

I'm not quite sure this has ever been obvious to me while going over the docs. Is that actually still the case?

/cc @mdo

mdo commented 4 years ago

Our docs and branding use a handful of primary colors to differentiate what is Bootstrap from what is in Bootstrap. In other words, if it’s purple, it’s representative of Bootstrap.

I'm not quite sure this has ever been obvious to me while going over the docs. Is that actually still the case?

Since I wrote that docs page, I have indeed kept that in my mind. It's less about the specific colors and more about differentiating what's documentation vs framework/toolkit. It's definitely why I customize the docs navbar, use purple in the left sidebar links, etc. Maybe I should clarify there.

patrickhlauke commented 4 years ago

more about differentiating what's documentation vs framework/toolkit

maybe i'm being dense, but i'm still not following here about what differentiation this is referring to. do you mean the actual parts that make up the getbootstrap site itself, and that there's some differentiation between "straight out of bootstrap" versus any special docs.scss customisation? if so, i never even noticed that before. too subtle perhaps? [edit: further, most examples in the actual docs/examples use bootstrap's defined palette - not the brand colors per se - so this is maybe even more confusing as a concept?]

and also...if this does refer to, essentially, "you can recognise things on this site as being vanilla bootstrap components that you will be able to use right away as well", is the "branding" page the best place for this info? might be better off in the getting started section (maybe introduction?)

[edit: further thoughts...perhaps rewriting this more along the lines of "this site, including all the documentation, is actually built using bootstrap, with a few exceptions: the copy/paste functionality, the code highlighting, ..."; this may make it much clearer, at least to me, both what the intention is and what the differentiation is]

use purple in the left sidebar links

not seeing this...they're gray, no?

patrickhlauke commented 4 years ago

i see #31248 removes the weird bit about "Our docs and branding use a handful of primary colors" ... so that PR closes this