twbs / bootstrap

The most popular HTML, CSS, and JavaScript framework for developing responsive, mobile first projects on the web.
https://getbootstrap.com
MIT License
169.85k stars 78.73k forks source link

Remove unreferenced CSS variable in `bootstrap-reboot*.css` #39533

Open mon-jai opened 8 months ago

mon-jai commented 8 months ago

Prerequisites

Proposal

The following CSS variables are not referenced in bootstrap-reboot*.css but are included in compiled assets.

They doubled the download size (6187 out of 12065 characters are CSS variables) with no real benefits. Maybe consider removing them in v6?

--bs-blue
--bs-indigo
--bs-purple
--bs-pink
--bs-red
--bs-orange
--bs-yellow
--bs-green
--bs-teal
--bs-cyan
--bs-black
--bs-white
--bs-gray
--bs-gray-dark
--bs-gray-100
--bs-gray-200
--bs-gray-300
--bs-gray-400
--bs-gray-500
--bs-gray-600
--bs-gray-700
--bs-gray-800
--bs-gray-900
--bs-primary
--bs-secondary
--bs-success
--bs-info
--bs-warning
--bs-danger
--bs-light
--bs-dark
--bs-primary-rgb
--bs-secondary-rgb
--bs-success-rgb
--bs-info-rgb
--bs-warning-rgb
--bs-danger-rgb
--bs-light-rgb
--bs-dark-rgb
--bs-primary-text-emphasis
--bs-secondary-text-emphasis
--bs-success-text-emphasis
--bs-info-text-emphasis
--bs-warning-text-emphasis
--bs-danger-text-emphasis
--bs-light-text-emphasis
--bs-dark-text-emphasis
--bs-primary-bg-subtle
--bs-secondary-bg-subtle
--bs-success-bg-subtle
--bs-info-bg-subtle
--bs-warning-bg-subtle
--bs-danger-bg-subtle
--bs-light-bg-subtle
--bs-dark-bg-subtle
--bs-primary-border-subtle
--bs-secondary-border-subtle
--bs-success-border-subtle
--bs-info-border-subtle
--bs-warning-border-subtle
--bs-danger-border-subtle
--bs-light-border-subtle
--bs-dark-border-subtle
--bs-white-rgb
--bs-black-rgb
--bs-font-sans-serif
--bs-gradient
--bs-body-color-rgb
--bs-body-bg-rgb
--bs-emphasis-color
--bs-emphasis-color-rgb
--bs-secondary-color-rgb
--bs-secondary-bg
--bs-secondary-bg-rgb
--bs-tertiary-color
--bs-tertiary-color-rgb
--bs-tertiary-bg
--bs-tertiary-bg-rgb
--bs-link-color
--bs-link-decoration
--bs-link-hover-color
--bs-border-style
--bs-border-color
--bs-border-color-translucent
--bs-border-radius
--bs-border-radius-sm
--bs-border-radius-lg
--bs-border-radius-xl
--bs-border-radius-xxl
--bs-border-radius-2xl
--bs-border-radius-pill
--bs-box-shadow
--bs-box-shadow-sm
--bs-box-shadow-lg
--bs-box-shadow-inset
--bs-focus-ring-width
--bs-focus-ring-opacity
--bs-focus-ring-color
--bs-form-valid-color
--bs-form-valid-border-color
--bs-form-invalid-color
--bs-form-invalid-border-color

Motivation and context

Reduce download/bundle size.

manviyadu1shi commented 7 months ago

@mon-jai Can this issue be assigned to me? I'll try my best

mon-jai commented 7 months ago

I am not a maintainer of this project. You should ask @julien-deramond instead.

manviyadu1shi commented 7 months ago

I am not a maintainer of this project. You should ask @julien-deramond instead.

Oh! Thanks for letting me know.

manviyadu1shi commented 7 months ago

@julien-deramond can this issue be asssigned to me?

julien-deramond commented 7 months ago

@julien-deramond can this issue be asssigned to me?

Hi @manviyadu1shi I'm off for a few weeks so sorry for the quick answer. As mentioned in our contributing guidelines we don't assign issues. Moreover, this one is labeled as v6 so it can't be started now as the v6 dev hasn't started yet.

manviyadu1shi commented 7 months ago

@julien-deramond can this issue be asssigned to me?

Hi @manviyadu1shi I'm off for a few weeks so sorry for the quick answer. As mentioned in our contributing guidelines we don't assign issues. Moreover, this one is labeled as v6 so it can't be started now as the v6 dev hasn't started yet.

Oh! Sorry , I should have read the contributing guidelines first. Got it. Thanks!