Fix link decoration handling in Bootstrap SCSS files

layenis commented 1 month ago

Description

This commit refactors the handling of link decorations in _buttons.scss, _card.scss, _dropdown.scss, _list-group.scss, _nav.scss, _navbar.scss, _pagination.scss files. The text-decoration property is now correctly applied based on the conditions specified by $link-decoration and $link-hover-decoration variables.

Motivation & Context

This change is required to fix issues related to the handling of link decorations in Bootstrap SCSS files introduced by another fix.

The original implementation attempted to optimize the handling of link decorations by excluding the text-decoration property under specific conditions. However, this led to incorrect behavior due to incomplete consideration of all possible values for $link-decoration and $link-hover-decoration.

This fix addresses these issues by ensuring proper handling of the text-decoration property based on specified conditions. Specifically, it ensures that the text-decoration property is correctly applied according to the values of $link-decoration and $link-hover-decoration, thereby resolving visual inconsistencies or unexpected rendering of link decorations.

Type of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Refactoring (non-breaking change)
[ ] Breaking change (fix or feature that would change existing functionality)

Checklist

[X] I have read the contributing guidelines
[X] My code follows the code style of the project (using npm run lint)
[ ] My change introduces changes to the documentation
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[ ] All new and existing tests passed

Live previews

https://deploy-preview-39934--twbs-bootstrap.netlify.app/

Related issues

Closes #39204

XhmikosR commented 1 month ago

Please make sure lint passes.

XhmikosR commented 3 weeks ago

@mdo: this changes the look in many places, please have a look (see the docs preview for example).

XhmikosR commented 3 weeks ago

If it's going to be so big of a change, maybe we should postpone it until later.

twbs / bootstrap