twbs / bootstrap

The most popular HTML, CSS, and JavaScript framework for developing responsive, mobile first projects on the web.
https://getbootstrap.com
MIT License
169.98k stars 78.74k forks source link

Icons as font instead of img #966

Closed andriijas closed 11 years ago

andriijas commented 12 years ago

Hi

Any reason you opted to include image based icons in bootstrap which are limited to the 16px dimensions?

For example http://somerandomdude.com/work/iconic/ is available as open source fonts - means you can include icons in headers, buttons of various size etc since its vector based.

Could easily be implemented with the same approach as the current icons:

i.foobar:before { content: "X" }

mahemoff commented 12 years ago

+1. I've integrated it and it's working great on both desktop and mobile.

rsaccon commented 12 years ago

+1 for adding Font Awesome to Bootstrap

Anahkiasen commented 12 years ago

+1

davegandy commented 12 years ago

@mahemoff Oooh. Where do you have it live? I'd love to see.

mneuhaus commented 12 years ago

+1

robmadole commented 12 years ago

:+1:

dbpolito commented 12 years ago

+1 for use FontAwesome :D

patrickoehlinger commented 12 years ago

FontAwesome looks great. So many possibilities ...

Why shouldn't it be in the core ?

supercodepoet commented 12 years ago

+1 for adding FontAwesome!

aozora commented 12 years ago

+1 for adding FontAwesome! It's awesome :)

AlbertoBasalo commented 12 years ago

+1 FortAwesome

Neema commented 12 years ago

+1 FontAwesome

brandonb927 commented 12 years ago

+1 for FontAwesome!

Looking to integrate FontAwesome into my next Bootstrap project

MechanisM commented 12 years ago

I don't wanna be "that guy" but why don't you like FontAwesome outside of Bootstrap? Just compile Bootstrap without icons and use FontAwesome instead.

@markdotto http://www.gonzoblog.nl/2012/01/8-high-quality-and-free-icon-fonts-available-for-embedding/ Btw Bootsrap deserves own icons to be designed and built into font and/or image sprites.

fcambus commented 12 years ago

FontAwesome is awesome indeed! Would clearly be a nice addition.

jplock commented 12 years ago

+1!

linlis commented 12 years ago

+1 for FontAwesome!

martianboy commented 12 years ago

:+1: for FontAwesome!

elsewares commented 12 years ago

+1 for FontAwesome. SVG ftw.

addyosmani commented 12 years ago

+1 FontAwesome. Terrific work getting this together btw.

assembler commented 12 years ago

:+1 FontAwesome

jdeblank commented 12 years ago

+1 FontAwesome

sindresorhus commented 12 years ago

:+1: FontAwesome :space_invader:

adamjgrant commented 12 years ago

For those of you wishing to use FontAwesome with Bootstrap, Kickstrap is a full version of Bootstrap using a layer of enhancements on top of Bootstrap.

It's not technically finished (I have a lot of documentation to write and I'd like to add support for using only css instead of Less) but since I see so much interest for FA integration, Kickstrap today should be very functional if you use a LESS compiler. This includes Font Awesome support by default. Kickstrap is due mid-April.

Get Kickstrap

mikedfunk commented 12 years ago

:+1:

sannefoltz commented 12 years ago

+1 FontAwesome, awesome work!!!!

ghost commented 12 years ago

+1 for Entypo

twoolie commented 12 years ago

+1 for FontAwesome and IcoMoon!

danielbruce commented 12 years ago

Beta version of the experimental scripts to automate Entypo font building can be viewed here.

Blame me for the unorthodox design of some glyphs and applaud @puzrin for an amazing job with everything else.

puzrin commented 12 years ago

Hello all, again. I'm almost finished scripts to generate fonts from SVG. Thanks to Daniel for permission to experiment with Entypo and providing sources.

I hope, that scripts will motivate new people to make more iconic fonts. Since we are all interested in it, please, help me to test quality of generated data http://danielbruce.github.com/entypo/demo.html :

  1. Are hinted font images ok (in different sizes, different browsers) ?
  2. I'm not CSS expert. Please, help to fix CSS/HTML templates, to work in all browsers.
  3. Please, help to resolve problem with showing new unicode chars in Opera 1 2

Links:

Entypo repo: https://github.com/danielbruce/entypo Entypo demo page: http://danielbruce.github.com/entypo/demo.html Instructions: https://github.com/danielbruce/entypo/blob/master/DEVELOPMENT.md

If you like to discuss only scripting / html / css issues, without disturbing Daniel, use my repo: https://github.com/fontello/entypo

adamjgrant commented 12 years ago

Excellent work.

misterdai commented 12 years ago

+1 for Entypo as they're more open than Glyphicons. Plus the designer has already commented that he's happy to be involved. Meaning it'd be easier to support all the current icons (no breaking changes) and extend the set. Even if we stuck with image based, I'd still prefer Entypo.

-1 for Font-Awesome. Sorry but turning the Glyphicons halflings set into a font feels wrong (although allowed via the "remix" clause). Only because the author "Jan Kovařík" wants to sell larger/extended versions and it feels like we're getting that for free.

pokonski commented 12 years ago

@misterdai so it feels wrong to use a free, made from scratch replacement than paying for something inferior?

MechanisM commented 12 years ago

+1 for Entypo

misterdai commented 12 years ago

@pokonski I'm only taking that stance because Entypo exists, which in my opinion looks just as nice but is more openly licensed and the designer @danielbruce is happy to provide additional icons. Makes the icons less encumbered.

pokonski commented 12 years ago

Ah yes. Fair enough. I considered those two +/- 1 as separate arguments ;)

puzrin commented 12 years ago

@misterdai, please, don't confuse people about licences. Dave's licence is CC-BY. It's the most open that exists now.

If his icon set is intentionally done "compatible" with previous raster icons, that doesn't meen, that it is dependent/remix. All his work is done from scratch.

misterdai commented 12 years ago

@puzrin Sorry didn't mean to confuse and I should have checked my facts better. Entypo uses a simlar CC-BY license but with the additional clause of "Share Alike", covering anything based on the icons requiring the same license.

Okay, ignore my previous points about licensing. I'm just more for Entypo due to designer involvement to provide more icons to the project.

puzrin commented 12 years ago

Dave also accepts requests about new icons for his font. No points left :)

PS. personally, i prefer Entypo. But i discuss font generation/quality details with all font authos (David, Dave, PJ).

misterdai commented 12 years ago

@puzrin only the point about feeling bad for Jan Kovařík since he's trying to make a bit of money with additional Glyphicons. But I guess that's just me ;)

adamjgrant commented 12 years ago

But do the extended icons mirror the extended glyphicons?

Envoyé de mon iPhone

Le Apr 3, 2012 à 4:23 AM, David Boyerreply@reply.github.com a écrit :

+1 for Entypo as they're more open than Glyphicons. Plus the designer has already commented that he's happy to be involved. Meaning it'd be easier to support all the current icons (no breaking changes) and extend the set. Even if we stuck with image based, I'd still prefer Entypo.

-1 for Font-Awesome. Sorry but turning the Glyphicons halflings set into a font feels wrong (although allowed via the "remix" clause). Only because the author "Jan Kovařík" wants to sell larger/extended versions and it feels like we're getting that for free.


Reply to this email directly or view it on GitHub: https://github.com/twitter/bootstrap/issues/966#issuecomment-4896582

iki commented 12 years ago

Great work @puzrin, @danielbruce, @davegandy, thank you. I'm currently using Font Awesome, as it is beautiful and ready to use with Bootstrap and less/scss/sass. But I really like the option to mix a custom font set in Fontomas.

Vitaly, can you include http://fortawesome.github.com/Font-Awesome on Fontomas? I found it already in assets/fonts, build_embedded_fonts.py and generated embedded_fonts.js, but I still don't see it on http://nodeca.github.com/fontomas. Is there anything else needed?

Also it would be great to generate the icon assignments in Fontomas in a css/less/scss compatible format that is ready to use with Bootstrap: .icon-NAME:before { content: "\CHAR_UNICODE"; } Can we help editing the icon names somewhere?

puzrin commented 12 years ago

@iki:

  1. Fontomas master branch contains bleeding edge dev version. And gh-pages - first release (tagged as 0.0.1). I think, next one will be released in 2-4 weeks. With font awesome included, of cause.
  2. https://github.com/fontello - here we repack all OFL fonts (rescale to the same grid, fix offset, regenerate hinting, add style names, remap glyph codes). Will add Websymbols & Font Awesome soon.

Yes, i really need help with HTML/CSS issue, because i'm not good in those, and concentrated on scriptting / usability.

  • Something should be done arount IE7 support.
  • Renaming css styles
  • Defining mapping in PUA for icons, missed in unicode 6.1 (it doesn't matter for single font, but make sence when you merge several ones)
  • Deciding, what to do with voice over (some doesn't ignore :before content). I'm strongly against moving all glyphs in PUA, because it breaks unicode standard.

If you like to help - contact me on email.

PS. \escaped codes can't be used if you like to support Unicode 6.1. Because Google Crome fails with 3-byte escapes. It supports only 2-bytes escaped chars. But sinse CSS generation is completely automated, i don't see big problem with direct chars in CSS.

Anyway, this problem doesn't affect my scripts, and out of my competence. I can generate any html/css, but someone html5-skilled should tell me, what to place there :)

sevenseacat commented 12 years ago

FontAwesome is great - thanks!

AnthonyPAlicea commented 12 years ago

+1 for FontAwesome!

donpark commented 12 years ago

+1 FontAwesome w/hinting

sebilasse commented 12 years ago

sorry for opening a new issue before reading this... FontAwesome could (should) be mentioned in the bootstrap documentation as an alternative ...

mikedemarais commented 12 years ago

+1 FontAwesome w/hinting

Synchro commented 12 years ago

+1 for FontAwesome too, and I can also report that attempts at IE7 compatibility are working, should be in next version.

puzrin commented 12 years ago

Fontomas v2 pre-release http://fontello.com/ . Feedback in tracker welcome. Changelog