Unnecessary use of 'bootstrap icon' classes in various example folders

twbs / examples

Functional examples of using Bootstrap in common JS frameworks like Webpack, Parcel, Vite, and more!

MIT License

490 stars 281 forks source link

Closed AshBardhan closed 4 months ago

AshBardhan commented 4 months ago

For multiple example folders (except icons-font folder)

The bootstrap-icons npm dependency is not included in their package.json file.
SVG icons are directly used and aligned inside the flexbox container.

Hence, it is better to remove bi and other variant classes from these example files to avoid confusion.

XhmikosR commented 4 months ago

I'd rather keep the classes. The fact that we inline some of the icons doesn't mean they shouldn't be as close to the upstream icons.

AshBardhan commented 4 months ago

I think we should either use such bootstrap icon classes when required or don't use them at all.