Icon Filenames for the shield icons are inconsistent in "bootstrap-icons": "^1.4.1"

[saurav2799]

Icon Filenames for the shield icons are inconsistent in "bootstrap-icons": "^1.4.1"

the scheme, as understood is bi-iconname and bi-iconname-fill for the unfilled and background filled icon names. for the shield icons, this has become bi-iconname and bi-fill-iconname. this is making it an issue, when using in navigation components with activelink highlight options. (please see picture, comparison of shield with other active icons).

the css login is simple to add a '-fill' to the end of the icon when rendering it with the primary tag.

like bi-house-door to bi-house-door-fill is working , but bi-shield-check to bi-shield-check-fill will not work, since the filename is bi-shield-fill-check

<Link to={`dynamic-link`}
    className={`nav-link m-0 py-0 ${(item.name).toLowerCase() === Activelink() ? 'text-primary' : 'text-dark'}`}>             
   <i className={`m-0 p-0 ${item.icon}${(item.name).toLowerCase() === Activelink() ? '-fill' : ''}`} </i>
  <p className="text-mini m-0 p-0">{item.name}</p>
 </Link>

• Operating system and version (Windows, macOS, Android, iOS) - All
• Browser and version (Chrome, Firefox, Safari, Microsoft Edge, Opera, Android Browser) - All

[mdo]

Unfortunately might have to make this change in a v2 release as it'd be a breaking change to rename a glyph IMO.

[RubenVerg]

what about duplicating them and requesting deprecation wherever possible (eg in the various thirty party components)? V2 would drop them but there would be knowledge before that

[korki43]

I'll have a look on it. I think creating a 'deprecated' category and hiding those elements from search would be enough.

[korki43]

@mdo #1119 also changed icon names and was published in a patch (1.7.2).