Add unit tests for Ratchet's JS libs

kkirsche commented 9 years ago

Are you looking to stick with QUnit as you guys use in Bootstrap or are you interested in something like Jasmine or Mocha?

Johann-S commented 9 years ago

What's the interest of using Jasmine or Mocha instead of QUnit ?

cvrebert commented 9 years ago

I don't think any pull request adding unit tests would be rejected on account of which unit testing library was chosen by its author.

kkirsche commented 9 years ago

My thoughts on pluses and minuses to each @johann-s (feel free to disagree though as a lot of opinion based)

QUnit:

Pros:

Lots of support across the board, from Q&A to CI server support

Cons:

Lacks fluent syntax
Configuration is a headache, and must constantly be maintained
Makes including 3rd party libraries (like assertion libraries) relatively difficult
Asynchronous testing can be a bit of a headache
No baked-in headless run support

Jasmine

Pros:

Simple setup for node through jasmine-node
Headless running out of the box
Nice fluent syntax for assertions built-in, and does play pretty well with other assertion libraries
Supported by many CI servers (TeamCity, Codeship, etc.) and some that don’t support natively have plugins (jenkins has a maven plugin)
Descriptive syntax for BDD paradigm

Cons:

Asynchronous testing can be a bit of a headache
Expects a specific suffix to all test files (*spec.js by default)

Mocha

Pros:

Simple setup
Headless running out of the box
Allows use of any assertion library that will throw exceptions on failure, such as Chai
Supported by some CI servers and plugins for others (jenkins has a maven plugin)
Has aliases for functions to be more BDD-oriented or TDD-oriented
Highly extensible
Asynchronous testing is a breeze

Cons:

Newer to the field, so support might be lacking in certain areas

Johann-S commented 9 years ago

Apparently @cvrebert is open to every unit testing library. Thanks @kkirsche for your thougthts it was very interesting.

I only know QUnit and Jasmine and that's right Jasmine is very simple to setup and learn. In all cases it would be very usefull to have unit test on Ratchet.

Just to know, Is it possible on SauceLab to test for specific devices @cvrebert ?

cvrebert commented 9 years ago

See https://saucelabs.com/platforms/#android

twbs / ratchet