Open MoritzLost opened 2 months ago
@julien-deramond is this correct or all of the deprecation warnings on bootstrap main branch are coming for there?
If we have warnings coming from rfs, we should fix them here and update the included version in Bootstrap.
Bootstrap main branch is fixed via https://github.com/twbs/bootstrap/pull/40623 (and will be available with v5.3.4). I don't know well this repository, maybe there are also specific fixes to do here. When do we see these deprecation warnings in this repository? Running which commands?
In theory updating sass in this repo to the latest version and running all tests should reveal any warnings.
For example I see this here https://github.com/twbs/examples/actions/runs/10684628167/job/29615519708?pr=496
┌──> node_modules/bootstrap/scss/_type.scss
38 │ font-family: $display-font-family;
│ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ declaration
╵
┌──> node_modules/bootstrap/scss/vendor/_rfs.scss
136 │ ┌ @media (#{$rfs-mq-property-width}: #{$rfs-mq-value}) {
137 │ │ @content;
138 │ │ }
│ └─── nested rule
╵
node_modules/bootstrap/scss/_type.scss 38:5 @import
which points to rfs
SASS is introducing a breaking change regarding the output order of nested SCSS rules: https://sass-lang.com/documentation/breaking-changes/mixed-decls/
To help prepare for this, SASS is outputting some deprecation warnings starting with
1.77.7
. I'm getting multiple warnings fromrfs
related to this issue. The affected areas will likely need to change the order of the declarations to get rid of those warnings and prepare for the breaking change, to ensure the variables will still have the correct order (and thereby, precedence).