twchapman / nativeclient-sdk

Automatically exported from code.google.com/p/nativeclient-sdk
0 stars 0 forks source link

sp: VatToUtf8() in <example>.c #113

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Following the tutorial, I created a new project as specified by:
http://code.google.com/chrome/nativeclient/docs/tutorial.html

Instead if using the default, I used the '-c' switch on python init_project.py 
to generate a 'C' project.

While reading the 'C' code to determine how to make the same change as the C++ 
example, I noticed that 
the comment for the first function of the generated C file says:

* Returns a mutable C string contained in the @a var or NULL if @a var is not
 * string.  This makes a copy of the string in the @a var and adds a NULL
 * terminator.  Note that VarToUtf8() does not guarantee the NULL terminator on
 * the returned string.  See the comments for VatToUtf8() in ppapi/c/ppb_var.h

The last line should be 'VarToUtf8' not 'VatToUtf8'.

Original issue reported on code.google.com by noelal...@google.com on 11 Aug 2011 at 6:05

GoogleCodeExporter commented 8 years ago
CL: http://codereview.chromium.org/7645031/

Original comment by dsprin...@chromium.org on 15 Aug 2011 at 7:47

GoogleCodeExporter commented 8 years ago

Original comment by dsprin...@chromium.org on 15 Aug 2011 at 8:05