update_manifest.py crashes if version number is "0" (even if string escaped)

[GoogleCodeExporter]

What steps will reproduce the problem?
1. run update_manifest.py with valid arguments and give it a "-b 0" and -B "x"
2.
3.

What is the expected output? What do you see instead?

expect it to create a manifest section with version 0.x

Instead it crashes with the following output:

http://commondatastorage.googleapis.com/nativeclient-mirror/nacl/nacl_sdk/gdb_bu
ilds/0.1/gdb-win-builds.tgz -r "no" -s "beta" 
Traceback (most recent call last):
  File "update_manifest.py", line 86, in <module>
    sys.exit(main(sys.argv[1:]))
  File "update_manifest.py", line 81, in main
    manifest_file.UpdateWithOptions(options)
  File "/home/mlinck/dev/git/nacl-sdk-git/src/build_tools/sdk_tools/sdk_update.py", line 850, in UpdateWithOptions
    self._manifest.UpdateManifest(options)
  File "/home/mlinck/dev/git/nacl-sdk-git/src/build_tools/sdk_tools/sdk_update.py", line 744, in UpdateManifest
    self._UpdateBundle(options)
  File "/home/mlinck/dev/git/nacl-sdk-git/src/build_tools/sdk_tools/sdk_update.py", line 679, in _UpdateBundle
    bundle.Update(options)
  File "/home/mlinck/dev/git/nacl-sdk-git/src/build_tools/sdk_tools/sdk_update.py", line 568, in Update
    self.Validate()
  File "/home/mlinck/dev/git/nacl-sdk-git/src/build_tools/sdk_tools/sdk_update.py", line 503, in Validate
    raise Error('Bundle "%s" is missing a version number' % self[NAME_KEY])
sdk_update.Error: Bundle "bundle_name" is missing a version number

Please use labels and text to provide additional information.

Original issue reported on code.google.com by mli...@google.com on 6 Oct 2011 at 11:56

[GoogleCodeExporter]

I'll take this.

Original comment by mball@google.com on 7 Oct 2011 at 1:42

[GoogleCodeExporter]

Committed as r1238

Original comment by mball@google.com on 10 Oct 2011 at 4:05

• Changed state: Fixed