search

twcloud / tiddlyweb-sse

MIT License
10 stars 3 forks source link

bug: Uncaught TypeError: Cannot read properties of undefined (reading 'syncadaptor') #346 #4

Closed linonetwo closed 1 year ago

linonetwo commented 1 year ago

tiddly-gittly/TidGi-Desktop#346

Caused in single html wiki https://github.com/tiddly-gittly/Tiddlywiki-NodeJS-Github-Template

linonetwo commented 1 year ago

@Arlen22 do you still active? I think I may have to fork this repo to https://github.com/tiddly-gittly/

Arlen22 commented 1 year ago

Yes, I am. Hadn't seen this before. I'll look into it.

linonetwo commented 1 year ago

Maybe you haven't watch the issue of this repo.

Thanks, today another tiddloid user report this.

linonetwo commented 1 year ago

@Arlen22 This is causing more troubles! Bump for a fix

Arlen22 commented 1 year ago

@linonetwo , the startup tiddler $:/plugins/twcloud/tiddlyweb-sse/sse-client.js requires the tiddlyweb syncadaptor to be active.

I'll fix one of the things that I see here, which should at least make the plugin properly inert when the tiddlyweb syncadaptor is not available. Hopefully that fixes the issue for you.

linonetwo commented 1 year ago

Thanks, not prompint error is enough for users to accept this.

How will you release it? CPL point to https://github.com/twcloud/tiddlyweb-sse/releases/latest/download/plugin.info , if you update that json (by a new release! And don't forget to upgrade version info), users can click the upgrade button to fix it for them. https://tw-cpl.netlify.app/#twcloud%2Ftiddlyweb-sse

linonetwo commented 1 year ago

@Arlen22 better rename plugin.info to plugin.json

linonetwo commented 1 year ago

@Arlen22 Users are still suffering from this bug!

图片

Arlen22 commented 1 year ago

@linonetwo is that because they haven't updated? Or is that based on master? Just checking. I'm working on a release right now.

Arlen22 commented 1 year ago

Ok, I added the release. Could you check it and let me know if I did everything right? Thanks.

Arlen22 commented 1 year ago

@linonetwo , I also added https://github.com/twcloud/tiddlyweb-sse/pull/2 as a separate release. Please check both of them and make sure they are working properly. Thanks.

linonetwo commented 1 year ago

Thanks， I think this works. Let me update the CPL later.

Only after that, user can receive updates.

linonetwo commented 1 year ago

CPL is serving latest version, thanks.