tweag / FawltyDeps

Python dependency checker
Other
201 stars 14 forks source link

Publish FawltyDeps to PyPI as part of the CI #124

Open Xophmeister opened 1 year ago

Xophmeister commented 1 year ago

Is your feature request related to a problem? Please describe. It's an extra human step, that needs coordinating and requires time, to push builds to an external repository.

Describe the solution you'd like GitHub Actions have enough fidelity such that release versions of FawltyDeps can be automatically pushed to PyPI.

Describe alternatives you've considered n/a

Additional context Secrets management will become a thing... but I think the GitHub Actions secrets will be good enough for this use-case.

See also #100

jherland commented 1 year ago

For now we have uploaded manually, and I was planning to "formalize" this process (including creating the release tag and doing the poetry build + poetry publish) in a manually triggered Nox action. This action would still rely on the developer triggering it having configured their PyPI credentials properly in order to the publishing to work from their local machine/environment.

It sounds like what you're proposing is one step further: having the tagging(?), building and publishing all run within GitHub CI. If so, what triggers this action? Surely it does not run on every commit?

Xophmeister commented 1 year ago

You could have it trigger on a release, so it doesn't trigger on every commit/PR.

mknorps commented 1 year ago

Implementation plan:

mknorps commented 1 year ago

https://py-pkgs.org/07-releasing-versioning.html#step-3-bump-version-number